Refactors CLI commands to use dependency injection #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jyecusch is attempting to deploy a commit to the Nitric Team on Vercel. A member of the Team first needs to authorize it. |
|
Also fixes errors that occurred when the user is logged out but used commands that require auth tokens. Before: After: |
To enable more granular testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #859 +/- ##
=======================================
Coverage ? 47.57%
=======================================
Files ? 23
Lines ? 2804
Branches ? 0
=======================================
Hits ? 1334
Misses ? 1380
Partials ? 90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tjholm
approved these changes
Jul 10, 2025
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
further reduces coupling between cli services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the CLI commands (access-token, login/logout, templates, and build) to utilise dependency injection for authentication and the nitric client.
Dependenciesstruct to encapsulate dependencies such as the WorkOS authentication client and Nitric API client.NewAccessTokenCmd) to accept aDependenciesinstance.